PE-D bug fixes #166
Merged
PE-D bug fixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffinsonDarmawan
added
type.Bug
IanFH
approved these changes
Apr 11, 2024
Comment on lines
+73
to
+76
| int newQuantity = currentQuantity + quantity; | ||
| if ((quantity > 0 && currentQuantity > Integer.MAX_VALUE - quantity) || newQuantity < 0) { | ||
| throw new FlorizzException("You have added too much flowers!"); | ||
| } |
There was a problem hiding this comment.
Great catching of large value exceptions!
JeffinsonDarmawan
merged commit 3ba51d6
into
AY2324S2-CS2113-T11-3:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs on: